Initial Rust binding #340
Merged
Initial Rust binding #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds initial Rust binding for Themis.
The code comes from here, version 0.0.2:
https://github.com/ilammy/rust-themis
I could have transferred the whole git history, but that's too much of
a bother and I don't think anybody would be interested in it that much.
If you wish to read the older commit messages you can always look into
the original repo. Not very convenient but that's at least something.
The core repository layout is a bit different from a traditional one
for Rust projects. I have moved the files into appropriate places and
adapted the Cargo.toml file to that. Importantly, it now requires an
`include` directive so that published crates include only Rust code.
Here's the current layout of Rust code:
.
├─ Cargo.toml - root Cargo.toml file
├─ docs/examples
│ └─ rust - Rust wrapper examples
├─ src/wrappers/themis
│ └─ rust - root of the "themis" crate
│ ├─ libthemis-sys - root of the "libthemis-sys" crate
│ └─ src - Rust wrapper source code
└─ tests
└─ rust - Rust wrapper tests
The Cargo.toml file is placed in the root directory so that all usual
Cargo commands work from there after a fresh checkout. They do work
indeed, but the Rust binding is not integrated into the core build
system. We'll improve that later.
The links throughout the docs and Cargo.toml files have been updated to
point to Cossack Labs repo. I have also removed TravisCI badges because
Rust wrapper is going to use CircleCI just like the other bindings.
I have kept the original README files. These are used when publishing on
crates.io and contain Rust-specific instructions. The LICENSE files in
Rust wrappers are also kept intact in accordance with item 4.a of the
Apache 2.0 license.
As for licensing of this contribution, I'm not a lawyer, but Apache
license gives the same rights to the original licensor as well as any
future contributors. That's why I did not bother updating all the
boilerplate comments all over the code. They still assign copyright of
Rust code to "rust-themis developers". By submitting this code to the
core repository the developers agree to keep the Apache 2.0 license
for it, as per item 5 of the license. There are no separate prior
agreements other than that.
|
Yey, themis will have rust binding, that's incredible! Thank you @ilammy, you're doing great things! Please don't be irritated while we're reading code and asking simple questions – rust is still very new for us.
That's right, having Apache 2.0 license makes total sense, as you said, it gives the same rights to the original licensor as well as any future contributors. |
Lagovas
reviewed
Jan 8, 2019
| #[derive(Clone, Eq, PartialEq, Hash)] | ||
| pub(crate) struct KeyBytes(Vec<u8>); | ||
|
|
||
| // TODO: securely zero memory when dropping KeyBytes (?) |
There was a problem hiding this comment.
will be good if you add it now. it's really important and easy in rust as I understand. to be sure that keys will be filled with zeroes
There was a problem hiding this comment.
Thanks for good catch!
Zeroing private keys is gonna be part of next PR
shadinua
approved these changes
Jan 10, 2019
|
Agreed to merge this PR, and to add future Rust changes (including zeroing of private keys) into next PR |
This was referenced Jan 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial Rust binding for Themis.
The code comes from here, version 0.0.2:
https://github.com/ilammy/rust-themis
I could have transferred the whole git history, but that's too much of a bother and I don't think anybody would be interested in it that much. If you wish to read the older commit messages you can always look into the original repo. Not very convenient but that's at least something.
The core repository layout is a bit different from a traditional one for Rust projects. I have moved the files into appropriate places and adapted the Cargo.toml file to that. Importantly, it now requires an
includedirective so that published crates include only Rust code.Here's the current layout of Rust code:
The Cargo.toml file is placed in the root directory so that all usual Cargo commands work from there after a fresh checkout. They do work indeed, but the Rust binding is not integrated into the core build system. We'll improve that later.
The links throughout the docs and Cargo.toml files have been updated to point to Cossack Labs repo. I have also removed TravisCI badges because Rust wrapper is going to use CircleCI just like the other bindings.
I have kept the original README files. These are used when publishing on crates.io and contain Rust-specific instructions. The LICENSE files in Rust wrappers are also kept intact in accordance with item 4.a of the Apache 2.0 license.
As for licensing of this contribution, I'm not a lawyer, but Apache license gives the same rights to the original licensor as well as any future contributors. That's why I did not bother updating all the boilerplate comments all over the code. They still assign copyright of Rust code to "rust-themis developers". By submitting this code to the core repository the developers agree to keep the Apache 2.0 license for it, as per item 5 of the license. There are no separate prior agreements other than that.