Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BoringSSL for Themis iOS cocoapod #330

Merged
merged 22 commits into from
Oct 30, 2018
Merged

Conversation

vixentael
Copy link
Contributor

All below valid for Themis iOS/macOS wrapper and examples.

Should be merged after #223 .

I've tested Themis objcwrapper with BoringSSL iOS pod to make it possible to use Themis with BoringSSL and GRPC (as mentioned in #223).

  1. I've updated themis.podspec to contain two subspecs: themis-openssl (default) and themis-boringssl. Now users can specify to use BoringSSL as crypto-engine for Themis in their Podfile:
  pod 'themis/themis-boringssl'

See updated spec.

  1. iOS Themis with BoringSSL disables using XTS mode for AES, because it's not included into BoringSSL cocoapod (see Allow to disable reference of AES-256-XTS for Themis iOS #329).

  2. iOS Themis tests are running for both themis-openssl and themis-boringssl targets.

  3. New podspec is checked to be linted and built for iOS and macOS.

@vixentael vixentael added O-iOS 📱 Operating system: iOS core Themis Core written in C, its packages labels Oct 25, 2018
@vixentael
Copy link
Contributor Author

Do not merge until @sgammon confirms that updated Themis is compatible with GRPC :)

@vixentael vixentael self-assigned this Oct 25, 2018
@vixentael
Copy link
Contributor Author

NB: after publishing podspec do not forget to update all examples to use 0.10.1.

@vixentael
Copy link
Contributor Author

I've decided to update podspec and merge it to master, because I'll switch to other tasks soon, and will forget the context.

@vixentael
Copy link
Contributor Author

iOS examples were updated to use 0.10.1 and tested.

Main test project (tests/objcthemis) will be linked to use Themis from master in a separate PR (because podspec should be merged to master first).

@vixentael
Copy link
Contributor Author

Solves #223

@vixentael vixentael deleted the vixentael/ios-boringssl branch October 30, 2018 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Themis Core written in C, its packages O-iOS 📱 Operating system: iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant