Refactoring if (!pkey) in 'soter_sign_ecdsa.c' for OpenSSL/BoringSSL #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm henry wong, from Qihoo360 CodeSafe Team. We found a possible null pointer deference caused by the misusage of short-circuit evaluation. If 'pkey' is null, the program will continue execute 'EVP_PKEY_base_id(pkey)', and this will cause a null pointer dereference.
Fix the misusage of short-circuit evaluation in 'soter_sign_ecdsa.c'
ignatk
requested changes
May 10, 2018
tests/soter/soter_sign_test.c
Outdated
| @@ -211,7 +211,7 @@ static void soter_sign_api_test() | |||
| soter_sign_destroy(sign_ctx); | |||
| return; | |||
| } | |||
|
|
|||
Lagovas
approved these changes
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #314
We've added similar check into BoringSSL-related code.
Unfortunately we didn't find any ways to simulate NULL pKey using OpenSSL API.
Thank you @movie-travel-code!