Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use phpunit 6.3.1 for php 7.0 and 7.1 #303

Merged
merged 1 commit into from
Feb 1, 2018
Merged

use phpunit 6.3.1 for php 7.0 and 7.1 #303

merged 1 commit into from
Feb 1, 2018

Conversation

Lagovas
Copy link
Collaborator

@Lagovas Lagovas commented Feb 1, 2018

  • use last phpunit for php7.2+
  • use phpunit 6.3.1 for php 7.0 and 7.1
  • disabled testing memory leaks in php until we fix it to stop tests failure in circleci
  • add php tests for php 7.0, 7.1, 7.2 via different docker images (merged code from test php 7.0 and 7.1 #301 to test this PR)

@Lagovas Lagovas mentioned this pull request Feb 1, 2018
Closed
@vixentael vixentael merged commit 07ff78b into cossacklabs:master Feb 1, 2018
@vixentael vixentael added W-PHPThemis 🐘 Wrapper: PHPThemis, PHP API tests Themis test suite labels Feb 1, 2018
@Lagovas Lagovas deleted the lagovas/T417-fix-phptests branch February 6, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vixentael vixentael vixentael approved these changes

@mozhmike mozhmike Awaiting requested review from mozhmike

Assignees
No one assigned
Labels
tests Themis test suite W-PHPThemis 🐘 Wrapper: PHPThemis, PHP API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lagovas @vixentael