Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate pythemis install #300

Merged
merged 1 commit into from
Jan 30, 2018
Merged

separate pythemis install #300

merged 1 commit into from
Jan 30, 2018

Conversation

Lagovas
Copy link
Collaborator

@Lagovas Lagovas commented Jan 30, 2018

  • explicitly use python2 and python3
  • install python X version if exists, don't fail if one not exists (before installing come down when python2 not exists)
  • same with tests, test all versions that exists (2, 3, 2+3)
  • plus dropped linking phpthemis.so + fixed php.ini (because has a failure when tested locally and found that it is overhead)

@vixentael
Copy link
Contributor

Note for future us: Circle Ci launched & successfully run all 4 workflows, but is showing only one.

@vixentael vixentael merged commit 175a1b3 into cossacklabs:master Jan 30, 2018
@vixentael vixentael added tests Themis test suite W-PyThemis 🐍 Wrapper: PyThemis, Python API W-PHPThemis 🐘 Wrapper: PHPThemis, PHP API labels Jan 30, 2018
@Lagovas Lagovas deleted the lagovas/T408-fix-pythemis-install branch February 6, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vixentael vixentael Awaiting requested review from vixentael vixentael is a code owner

Assignees
No one assigned
Labels
tests Themis test suite W-PHPThemis 🐘 Wrapper: PHPThemis, PHP API W-PyThemis 🐍 Wrapper: PyThemis, Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lagovas @vixentael