Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compilable php7 version #278

Merged
merged 5 commits into from
Jan 15, 2018
Merged

compilable php7 version #278

merged 5 commits into from
Jan 15, 2018

Conversation

Lagovas
Copy link
Collaborator

@Lagovas Lagovas commented Jan 15, 2018

  • compilable on
$ php --version
PHP 7.2.1 (cli) (built: Jan  3 2018 06:02:01) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2017 Zend Technologies
  • pass integration tests php <-> php with secure cell
  • splitted code into several files

It's not completed version that can be used to update unit tests. After successful run unit tests with php7 we can be sure that it works correctly

@ignatk
Copy link
Contributor

ignatk commented Jan 15, 2018

Cool - lack of php7 support was really holding me back in my branch to migrate to Circle CI 2.0 (as well as newer Ubuntu test-image, because newer Ubuntu provides PHP7 by default).

@vixentael
Copy link
Contributor

vixentael commented Jan 15, 2018

Yes, that's super cool!

We'll close #178 issue after we update php5 and php7 unit tests, and probably refactor folder structure a bit, but overall, php7 support is a blast!

@vixentael vixentael added W-PHPThemis 🐘 Wrapper: PHPThemis, PHP API compatibility Backward and forward compatibility, platform interoperability issues, breaking changes labels Jan 15, 2018
@vixentael vixentael merged commit 08911a6 into cossacklabs:master Jan 15, 2018
@vixentael vixentael mentioned this pull request Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Backward and forward compatibility, platform interoperability issues, breaking changes W-PHPThemis 🐘 Wrapper: PHPThemis, PHP API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants