-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename error.h files #247
Rename error.h files #247
Conversation
I wanted to say that maybe we should rename themis/error.h to themis/themis_error.h and I remembered that this header file used in all wrappers... Did you check that soter/error.h not used anywhere in other parts of code?
what do you think about |
1
agree, i had the same thought. renamed. 2
well, i don't really like the name 3
I hope we have tests for that :D |
gothemis (in *.go files) uses themis/error.h and should be renamed too |
already did :) thankfully, we have good tests! |
Currently core has two
error.h
files: insidesoter
and insidethemis
folders. It might cause compiler warnings due to same names.Moreover, objc wrapper has
error.h
file inside too, this cause warning while building iOS (ObjC/Swift) examples.Previously mentioned:
Changes:
soter/error.h
tosoter/soter_error.h
objcthemis/serror.h
to `objcthemis/serror.h