run tests from makefile #244
Conversation
|
maybe we should refactor this makefile and make that and I would use this updated Makefile in our circle.yml |
|
Nice idea! But then we should update Makefiles for other products to be consistent :) I'll do it |
|
compile tests:
run tests:
by default, If it's ok for you, I'll update wiki |
Makefile
Outdated
| @@ -567,7 +526,7 @@ symlink_realname_to_soname: | |||
| strip: | |||
| @find . -name \*.$(SHARED_EXT)\.* -exec strip -o {} {} \; | |||
|
|
|||
| deb: test soter_static themis_static soter_shared themis_shared collect_headers install_shell_scripts strip symlink_realname_to_soname | |||
| deb: prepare_tests_basic soter_static themis_static soter_shared themis_shared collect_headers install_shell_scripts strip symlink_realname_to_soname | |||
There was a problem hiding this comment.
prepare_tests_baisc -> test_basic. run tests before building package
Makefile
Outdated
| @@ -610,7 +569,7 @@ deb: test soter_static themis_static soter_shared themis_shared collect_headers | |||
| @find $(BIN_PATH) -name \*.deb | |||
|
|
|||
|
|
|||
| rpm: test themis_static themis_shared soter_static soter_shared collect_headers install_shell_scripts strip symlink_realname_to_soname | |||
| rpm: prepare_tests_basic themis_static themis_shared soter_static soter_shared collect_headers install_shell_scripts strip symlink_realname_to_soname | |||
There was a problem hiding this comment.
prepare_tests_baisc -> test_basic. run tests before building package
There was a problem hiding this comment.
I can do it, but this PR won't be 'refactoring' anymore (because we're changing logic here, not just renaming)
There was a problem hiding this comment.
logic the same - test code before package building but before this logic was broken, but now you fix it and it's great
to finish this refactoring we should use new make test in our circle.yml instead of current commands:
...
- build/tests/soter_test
- build/tests/themis_test
- build/tests/themispp_test
- build/tests/pythemis_test.sh
- build/tests/phpthemis_test.sh
- build/tests/node.sh
...
what you think?
|
|
|
@Lagovas I think that we shouldn't use However, I did more research & refactoring on that, and got rid of running ruby tests with |
yeah, it's good when used public interface of Makefile (like you did now), not when used the implementation in recipes (as it was before). |
closes #243
checkcommandThis is required test suit.
check_allcommandThese tests require external dependencies, so they might fail due to outdated local configuration.