Some Magic numbers correction in Comparator for #196 #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good. I'm waiting response from @secumod about some crypto questions and then will add useful comments to the code |
ignatk
reviewed
May 23, 2017
| @@ -23,6 +23,9 @@ static themis_status_t secure_comparator_alice_step3(secure_comparator_t *comp_c | |||
| static themis_status_t secure_comparator_bob_step4(secure_comparator_t *comp_ctx, const void *input, size_t input_length, void *output, size_t *output_length); | |||
| static themis_status_t secure_comparator_alice_step5(secure_comparator_t *comp_ctx, const void *input, size_t input_length, void *output, size_t *output_length); | |||
|
|
|||
| #define HASH_LENGTH 64 //for sha512 | |||
| #define TEMP_BUFFER_LENGTH ((ED25519_GE_LENGTH>HASH_LENGTH)?ED25519_GE_LENGTH:HASH_LENGTH) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.