-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cherry-pick from release/0.15.0 to master. Part 3. Python Unittest #1057
base: master
Are you sure you want to change the base?
Conversation
…d on iOS 17, but OpenSSL 1.1 (#1021)
@Lagovas JFYI new pythemis test |
I don't understand why we need one more test? they test any new case or flow? or it's regression test for some incident? then will be great to see what incident caused problems in decryption data from ios app in python code |
in #1021 I see that was added tests but also don't see why we did it and for what |
that's just an additional test in our suite, it's a good thing |
okay, but what prompted you to add this test? maybe we need extend these tests instead of adding edge case without any reason to add it. it's clear for what if we had incident and it will be regression tests |
As we discuss the test, iOS 18 is already out. I don't mind forgetting about this test because it is no longer relevant. Finally, what should I do with the pull request? |
Let me explain why I don't like tests like that. These tests looks like we have function
We have a themis function that can use some math lib (openssl, boringssl) and returns result. This function can be compiled by different compilers and used by a lot of languages. And we calculated one result on one of the platform and test that it similar on the another platform. And it looks like we calculated 2+2 on ios15 and check that 2+2 the same on GH runner. And this test doesn't test anything related to ios15 instead of it was compiled on one of the real machine and stored. And no one can reproduce it again except Rad, who can probably change own env after the time. |
Add python unittests that check the compatibility with bytes generated on iOS 17, but OpenSSL 1.1 (#1021)
Checklist