-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsthemis: Downgrade mocha to ^7 for Centos7 #1003
Conversation
This version and all its transitive dependencies support node v8 which is the only version we can run on centos 7. It seems like other OS work fine, at least on buildbot. Another option is to fix our scripts on buildbot just for centos 7 so they patch the versions before testing. This may save us from future problems. However, downgrading dev dependency is not that scary, so maybe this approach is okay.
I would NOT downgrade mocha all builds on all platforms if we want to fix only centos 7. Maybe we can create a workaround for centos7 only? |
Sure! We can adjust buildbot scripts: add a step with |
You may try using the scripts section. For example:
And use the power of JS to install OS-specific dependencies. Also, it may be a shell script. And call the script before running the tests. |
Hmm, that is an option, thank you! However, it will collide with the node-gyp which we use to build the addon, so in this case we would have to explicitly call the node-gyp. So probably for these reasons npm doesn't recommend redefining However, if you believe this this the right way, I can do it. |
You may try using not only "install" or "preinstall" script names. Try "centos7_specific_tests_deps", for example. |
Add a separate script for that. It will be caled during make test.
@radetsky, could you take a quick look please. Does the last commit look like you described? |
Already did. Thank you. LGTM. Did you test it on centos7 and other OSes? |
Looks like buildbot tests are green, so thank you, @radetsky! |
This reverts commit 0e7df2e.
Nice one! @Lagovas WDYT? |
This version and all its transitive dependencies support node v8 which is the only version we can run on centos 7. It seems like other OS work fine with it, at least on buildbot.
Another option is to fix our scripts on buildbot just for centos 7, so they patch the versions before testing. This may save us from future problems or dependency issues. However, downgrading dev dependency is not that scary, so maybe this approach is okay.
Checklist
Benchmark results are attached (if applicable)The coding guidelines are followedPublic API has proper documentationExample projects and code samples are up-to-date (in case of API changes)Changelog is updated (in case of notable or breaking changes)