Skip to content

Commit

Permalink
Always ignore ldconfig failures
Browse files Browse the repository at this point in the history
PR #346 [1] has improved ldconfig handling a bit by failing the build
only when ldconfig is invoked as root. However, this causes issues when
building under fakeroot (which sets EUID but does not give permissions).
Furthemore, GNU Makefile conventions [2] expect ldconfig failures to be
simply ignored.

[1]: #346
[2]: https://www.gnu.org/prep/standards/html_node/Utilities-in-Makefiles.html
  • Loading branch information
ilammy committed Apr 9, 2019
1 parent bedd0b1 commit 101e479
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ install_pkgconfig: err all make_install_dirs

install: install_soter_headers install_themis_headers install_static_libs install_shared_libs install_pkgconfig
ifdef IS_LINUX
@ldconfig || (status=$$?; if [ $$(id -u) = "0" ]; then exit $$status; else exit 0; fi)
-@ldconfig
endif

get_version:
Expand Down

0 comments on commit 101e479

Please sign in to comment.