Use modern GoThemis 0.12 API #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoThemis 0.12 has deprecated some API names which broke Go conventions. Update the code to use new names. Note thate Secure Cell API is scheduled for an overhaul in the next version of GoThemis 0.13.
While I've been auditing uses of "gothemis" package I have noticed that in one place we have been erroneously using it's "errors" subpackage instead of the standard one.
Since GoThemis 0.12 it is possible to use properly versioned modules. Update go.mod accordingly.
Lagovas
approved these changes
Apr 9, 2020
ilammy
added a commit
that referenced
this pull request
Apr 9, 2020
(cherry picked from commit 61d0b8a) * Use modern GoThemis 0.12 API GoThemis 0.12 has deprecated some API names which broke Go conventions. Update the code to use new names. Note that Secure Cell API is scheduled for an overhaul in the next version of GoThemis 0.13. * Fix weird import or "errors" While I've been auditing uses of "gothemis" package I have noticed that in one place we have been erroneously using it's "errors" subpackage instead of the standard one. * Use versioned "gothemis" module Starting with GoThemis 0.12 it is possible to use properly versioned modules. Update go.mod accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoThemis 0.12 has deprecated some API names which broke Go conventions (cossacklabs/themis#424). Update the code to use new names.
Note that Secure Cell API is scheduled for an overhaul in the next version of GoThemis 0.13.
Also, since GoThemis 0.12 it is possible to use properly versioned modules. Update go.mod accordingly.
While I've been auditing uses of
gothemispackage I have noticed that in one place we have been erroneously using it'serrorssubpackage instead of the standard one.