This repository has been archived by the owner on Nov 29, 2024. It is now read-only.
use Vec::with_capacity avoid realloc mem #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkysg
commented
Nov 1, 2024
| prost::Message::merge(&mut parsed, op.data.as_slice())?; | ||
|
|
||
| proofs.push(parsed); | ||
| proofs[i] = parsed; |
There was a problem hiding this comment.
@srdtrk sir, maybe this small change is wrong, if proofs capacity is 10, but proofs length is 0, proofs[0] is index operation, it will panic.
There was a problem hiding this comment.
Huh, I thought the tests passed but I probably ran with wrong environment variables that skipped this. I'll revert
There was a problem hiding this comment.
Huh, I even left the comments. I made this push in a rush...
srdtrk
added a commit
that referenced
this pull request
Nov 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.