merge main

Makefile

@@ -22,7 +22,9 @@ test:
 test-system: build
 	mkdir -p ./tests/systemtests/binaries/
 	git clone https://github.com/cosmos/cosmos-sdk.git ./build/tmp/cosmos-sdk
-	cd ./build/tmp/cosmos-sdk && git checkout `grep -m 2 'github.com/cosmos/cosmos-sdk' ../../../go.mod | awk 'NR==2 {print $$4; exit} END{if(NR==1) print $$2}'`
+	$(eval SDK_VERSION := $(shell grep -m 2 'github.com/cosmos/cosmos-sdk' go.mod | awk 'NR==2 {print $$4; exit} END{if(NR==1) print $$2}'))
+	@echo "Checking out cosmos-sdk version: $(SDK_VERSION)"
+	cd ./build/tmp/cosmos-sdk && git checkout $(SDK_VERSION)
 	$(MAKE) -C ./build/tmp/cosmos-sdk build
 	cp ./build/tmp/cosmos-sdk/build/simd$(if $(findstring v2,$(COSMOS_BUILD_OPTIONS)),v2) ./tests/systemtests/binaries/
 	cp ./build/rosetta ./tests/systemtests/binaries/

README.md

@@ -54,7 +54,7 @@ An implementation example can be found in `simapp` package.
 
 To run Rosetta in your application CLI, use the following command:
 
-> **Note:** if using the native approach, add your node name before any rosetta comand.
+> **Note:** if using the native approach, add your node name before any rosetta command.
 
 ```shell
 rosetta --help
@@ -74,7 +74,7 @@ rosetta
 
 ## Plugins - Multi chain connections
 
-Rosetta will try to reflect the node types trough reflection over the node gRPC endpoints, there may be cases were this approach is not enough. It is possible to extend or implement the required types easily trough plugins.
+Rosetta will try to reflect the node types trough reflection over the node gRPC endpoints, there may be cases were this approach is not enough. It is possible to extend or implement the required types easily through plugins.
 
 To use Rosetta over any chain, it is required to set up prefixes and registering zone specific interfaces through plugins.
 

tests/systemtests/accounts_test.go

@@ -22,7 +22,8 @@ func TestAccounts(t *testing.T) {
 	toAddr := cli.AddKey("account2")
 	sut.StartChain(t)
 
-	cli.RunAndWait("tx", "bank", "send", fromAddr, toAddr, "1000000stake")
+	rsp := cli.RunAndWait("tx", "bank", "send", fromAddr, toAddr, "1000000stake")
+	systemtests.RequireTxSuccess(t, rsp)
 
 	rosetta.restart(t)
 	rosettaRest := newRestClient(rosetta)
@@ -32,6 +33,11 @@ func TestAccounts(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Equal(t, int64(8999999), gjson.GetBytes(res, "balances.0.value").Int())
 
+	// check recipient's balance after receiving tokens
+	res, err = rosettaRest.accountBalance(toAddr)
+	assert.NoError(t, err)
+	assert.Equal(t, int64(1000000), gjson.GetBytes(res, "balances.0.value").Int())
+
 	// check balance at genesis, before spent
 	res, err = rosettaRest.accountBalance(fromAddr, withBlockIdentifier("1"))
 	assert.NoError(t, err)

tests/systemtests/rosetta.go

@@ -82,6 +82,7 @@ func (r *rosettaRunner) start(t *testing.T) {
 
 	r.log("Start Rosetta\n")
 	r.logf("Execute `%s %s`\n", r.execBinary, strings.Join(args, " "))
+	// #nosec G204
 	cmd := exec.Command(locateExecutable(r.execBinary), args...)
 	cmd.Dir = r.outputDir
 	r.watchLogs(cmd)
@@ -103,8 +104,9 @@ func (r *rosettaRunner) awaitRosettaUp(t *testing.T) {
 			SetBody("{}").
 			Post("/network/list")
 		if err == nil {
-			bk := gjson.GetBytes(res.Body(), "network_identifiers.#.blockchain").Array()[0].String()
-			require.Equal(t, bk, "testing")
+			result := gjson.GetBytes(res.Body(), "network_identifiers.#.blockchain").Array()
+			assert.Greater(t, len(result), 0)
+			require.Equal(t, result[0].String(), "testing")
 			t.Log("Rosetta has been started\n")
 			return
 		}

tests/systemtests/test_runner.go

@@ -82,6 +82,7 @@ func requireEnoughFileHandlers(nodesCount int) {
 		return
 	}
 
+	// #nosec G204
 	cmd := exec.Command(ulimit, "-n")
 	cmd.Dir = systemtests.WorkDir
 	out, err := cmd.CombinedOutput()