Play with the verifier

[cwgoes]

Testing in progress.

[jackzampolin]

NOTE: TrustedValSet takes the height and subtracts 1 so this should return the valset from height - 1

With the code the way it is now, we get the following error when updating clients:

go run main.go --home $RLY tx update-client ibc0 ibc1 ibconeclient
{"height":"0","txhash":"FBE550310E4DCEF7E2CD040D975E71DA41E9E13A88F55C05CD3AA9B93988184C","codespace":"client","code":9,"raw_log":"invalid block header: header blocktime can't be in the future: cannot update client with ID ibconeclient","gas_wanted":"200000","gas_used":"50242"}

If we change this to height-1 and the below call to height then we get the following error:

go run main.go --home $RLY tx update-client ibc0 ibc1 ibconeclient
{"height":"0","txhash":"BE0E95CBAF0AC40E3D0005DB41EE47D7BFFB26EF6BBEDCEE7414900B7A4B9B4A","codespace":"undefined","code":1,"raw_log":"internal error","gas_wanted":"200000","gas_used":"50262"}

[cwgoes]

I just can't replicate this locally, at least not at the moment.

[cwgoes]

So, at the moment, I can do:

./two-chains.sh

(set environment variables accordingly)

Setting clients works fine:

relayer --home $RLY tx clients ibc0 ibc1 ibconeclient ibczeroclient

The first connection-step works fine:

relayer --home $RLY tx connection-step ibc0 ibc1 ibconeclient ibczeroclient ibconeconn ibczeroconn

The second fails:

relayer --home $RLY tx connection-step ibc0 ibc1 ibconeclient ibczeroclient ibconeconn ibczeroconn

{"height":"6","txhash":"6B954F53057A24C2DB194BE30FAA7834AC88406E7476AA8E64BD96970E375253","codespace":"client","code":14,"raw_log":"connection state verification failed: key mismatch on operation #0: expected ibconeconn but got connection/ibconeconn: failed to execute message; message index: 1","gas_wanted":"200000","gas_used":"116000"}

Also, to even get to this error, I have to alter the error logic again - cosmos/cosmos-sdk@7465f9b.

[cwgoes]

I'm not totally sure that my changes to the proof paths are correct; when I revert them I get:

{"height":"16","txhash":"E1D9E1CF1941043D0E5EC3BA49CF4F4A26AC460E6DE0CC20881BF85FB6067106","codespace":"client","code":14,"raw_log":"connection state verification failed: calculated root hash is invalid: expected [94 197 194 250 51 5 186 54 114 107 48 85 54 104 156 115 208 216 165 135 217 245 125 154 241 184 121 109 49 237 138 146] but got [28 0 255 77 7 105 199 212 24 235 180 224 30 86 54 56 202 188 117 51 97 98 167 201 44 223 63 151 73 178 147 38]: failed to execute message; message index: 1","gas_wanted":"200000","gas_used":"116003"}

(on the second connection step)

This error is after the key mismatch one though, per https://github.com/tendermint/tendermint/blob/master/crypto/merkle/proof.go#L60, so my earlier attempted fixes may not have fixed the problem anyways.

[cwgoes]

Switching https://github.com/cosmos/cosmos-sdk/blob/ibc-alpha/x/ibc/23-commitment/merkle.go#L91 to KeyEncodingHex does not help, same mis-match.

[cwgoes]

I'm pretty lost here, do you have any ideas @AdityaSripal / does this match your debugging?