Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: e2e tests for soft opt out #857

Merged
merged 7 commits into from
Apr 19, 2023
Merged

testing: e2e tests for soft opt out #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a00acb
add steps for opt out testing
shaspitz Apr 17, 2023
f62dc80
comments
shaspitz Apr 17, 2023
bfa4f1c
set soft opt out thresh in consumer genesis
shaspitz Apr 18, 2023
851d730
Merge branch 'main' into opt-out-e2e
shaspitz Apr 18, 2023
6d17ec2
Merge branch 'main' into opt-out-e2e
mpoke Apr 19, 2023
94fcf85
Merge branch 'main' into opt-out-e2e
shaspitz Apr 19, 2023
d0b882a
Merge branch 'main' into opt-out-e2e
shaspitz Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/e2e/actions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,9 +514,10 @@ func (tr TestRun) voteGovProposal(
}

type startConsumerChainAction struct {
consumerChain chainID
providerChain chainID
validators []StartChainValidator
consumerChain chainID
providerChain chainID
validators []StartChainValidator
genesisChanges string
}

func (tr TestRun) startConsumerChain(
Expand Down Expand Up @@ -545,7 +546,7 @@ func (tr TestRun) startConsumerChain(
consumerGenesis := ".app_state.ccvconsumer = " + string(bz)
consumerGenesisChanges := tr.chainConfigs[action.consumerChain].genesisChanges
if consumerGenesisChanges != "" {
consumerGenesis = consumerGenesis + " | " + consumerGenesisChanges
consumerGenesis = consumerGenesis + " | " + consumerGenesisChanges + " | " + action.genesisChanges
}

tr.startChain(StartChainAction{
Expand Down
63 changes: 57 additions & 6 deletions tests/e2e/step_delegation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,18 +127,69 @@ func stepsUnbond(consumerName string) []Step {
}
}

// stepsRedelegate tests redelegation and resulting validator power changes.
func stepsRedelegate(consumerName string) []Step {
// stepsRedelegateForOptOut tests redelegation, and sets up voting powers s.t
// alice will have less than 5% of the total voting power. This is needed to
// test opt-out functionality.
func stepsRedelegateForOptOut(consumerName string) []Step {
return []Step{
{
action: redelegateTokensAction{
chain: chainID("provi"),
src: validatorID("alice"),
dst: validatorID("carol"),
txSender: validatorID("alice"),
// Leave alice with majority stake so non-faulty validators maintain more than
amount: 450000000,
},
state: State{
chainID("provi"): ChainState{
ValPowers: &map[validatorID]uint{
validatorID("alice"): 60,
validatorID("bob"): 500,
validatorID("carol"): 950,
},
},
chainID(consumerName): ChainState{
ValPowers: &map[validatorID]uint{
// Voting power changes not seen by consumer yet
validatorID("alice"): 510,
validatorID("bob"): 500,
validatorID("carol"): 500,
},
},
},
},
{
action: relayPacketsAction{
chain: chainID("provi"),
port: "provider",
channel: 0,
},
state: State{
chainID(consumerName): ChainState{
ValPowers: &map[validatorID]uint{
// Now power changes are seen by consumer
validatorID("alice"): 60,
validatorID("bob"): 500,
validatorID("carol"): 950,
},
},
},
},
}
}

// stepsRedelegate tests redelegation and resulting validator power changes.
func stepsRedelegate(consumerName string) []Step {
return []Step{
{
action: redelegateTokensAction{
chain: chainID("provi"),
src: validatorID("carol"),
dst: validatorID("alice"),
txSender: validatorID("carol"),
// redelegate s.t. alice has majority stake so non-faulty validators maintain more than
// 2/3 voting power during downtime tests below, avoiding chain halt
amount: 1000000,
amount: 449000000,
},
state: State{
chainID("provi"): ChainState{
Expand All @@ -152,9 +203,9 @@ func stepsRedelegate(consumerName string) []Step {
chainID(consumerName): ChainState{
ValPowers: &map[validatorID]uint{
// Voting power changes not seen by consumer yet
validatorID("alice"): 510,
validatorID("alice"): 60,
validatorID("bob"): 500,
validatorID("carol"): 500,
validatorID("carol"): 950,
},
},
},
Expand Down
2 changes: 2 additions & 0 deletions tests/e2e/steps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ var happyPathSteps = concatSteps(
stepsDelegate("consu"),
stepsAssignConsumerKeyOnStartedChain("consu", "bob"),
stepsUnbond("consu"),
stepsRedelegateForOptOut("consu"),
stepsDowntimeWithOptOut("consu"),
stepsRedelegate("consu"),
stepsDowntime("consu"),
stepsRejectEquivocationProposal("consu", 2), // prop to tombstone bob is rejected
Expand Down
57 changes: 55 additions & 2 deletions tests/e2e/steps_downtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,62 @@ func stepsDowntime(consumerName string) []Step {
},
},
},
}
}

// TODO: Test full unbonding functionality, tracked as: https://github.com/cosmos/interchain-security/issues/311

// stepsDowntimeWithOptOut returns steps validating that alice can incur downtime
// and not be slashed/jailed, since her voting power is less than 5% of the total.
//
// Note: 60 / (60 + 500 + 950) ~= 0.04
func stepsDowntimeWithOptOut(consumerName string) []Step {
return []Step{
{
action: downtimeSlashAction{
chain: chainID(consumerName),
validator: validatorID("alice"),
},
state: State{
// powers not affected on either chain
chainID("provi"): ChainState{
ValPowers: &map[validatorID]uint{
validatorID("alice"): 60,
validatorID("bob"): 500,
validatorID("carol"): 950,
},
},
chainID(consumerName): ChainState{
ValPowers: &map[validatorID]uint{
validatorID("alice"): 60,
validatorID("bob"): 500,
validatorID("carol"): 950,
},
},
},
},
{
action: relayPacketsAction{
chain: chainID("provi"),
port: "provider",
channel: 0,
},
state: State{
chainID("provi"): ChainState{
ValPowers: &map[validatorID]uint{
// alice is not slashed or jailed due to soft opt out
validatorID("alice"): 60,
validatorID("bob"): 500,
validatorID("carol"): 950,
},
},
chainID(consumerName): ChainState{
ValPowers: &map[validatorID]uint{
validatorID("alice"): 60,
validatorID("bob"): 500,
validatorID("carol"): 950,
},
},
},
},
}
}

Expand Down
6 changes: 6 additions & 0 deletions tests/e2e/steps_start_chains.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,12 @@ func stepsStartConsumerChain(consumerName string, proposalIndex, chainIndex uint
{id: validatorID("alice"), stake: 500000000, allocation: 10000000000},
{id: validatorID("carol"), stake: 500000000, allocation: 10000000000},
},
// For consumers that're launching with the provider being on an earlier version
// of ICS before the soft opt-out threshold was introduced, we need to set the
// soft opt-out threshold to 0.05 in the consumer genesis to ensure that the
// consumer binary doesn't panic. Sdk requires that all params are set to valid
// values from the genesis file.
genesisChanges: ".app_state.ccvconsumer.params.soft_opt_out_threshold = \"0.05\"",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No biggie, but couldn't this be 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 is a valid value for that param, but setting it to 0 would make the test fail (just confirmed) and wouldn't validate the feature. It'd essentially mean 0% of validator set is allowed to opt out

},
state: State{
chainID("provi"): ChainState{
Expand Down