Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(types): refactor Default implementations with concrete names #1099

Merged
merged 40 commits into from
Mar 12, 2024

chore: update unclog

46910f3
Select commit
Loading
Failed to load commit list.
Merged

imp(types): refactor Default implementations with concrete names #1099

chore: update unclog
46910f3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 12, 2024 in 0s

66.57% (+0.03%) compared to d0511b7

View this Pull Request on Codecov

66.57% (+0.03%) compared to d0511b7

Details

Codecov Report

Attention: Patch coverage is 83.66013% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 66.57%. Comparing base (d0511b7) to head (46910f3).

Files Patch % Lines
ibc-core/ics03-connection/types/src/connection.rs 8.33% 11 Missing ⚠️
...s/ics721-nft-transfer/src/handler/send_transfer.rs 0.00% 5 Missing ⚠️
ibc-apps/ics721-nft-transfer/src/module.rs 0.00% 3 Missing ⚠️
ibc-apps/ics721-nft-transfer/types/src/memo.rs 25.00% 3 Missing ⚠️
ibc-apps/ics721-nft-transfer/types/src/class.rs 83.33% 1 Missing ⚠️
ibc-apps/ics721-nft-transfer/types/src/data.rs 66.66% 1 Missing ⚠️
ibc-testkit/src/testapp/ibc/clients/mock/header.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1099      +/-   ##
==========================================
+ Coverage   66.54%   66.57%   +0.03%     
==========================================
  Files         209      209              
  Lines       20617    20636      +19     
==========================================
+ Hits        13719    13738      +19     
  Misses       6898     6898              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.