Commits on Feb 7, 2022

1. Added ChannelId to MsgChannelOpenInitResponse (#848) …

   ## Description
   added ChannelId to MsgChannelOpenInitResponse
   this is needed for distribution within interchain security
   
   Also my go imports didn't like go metrics so I had to add the go-metrics alias
   
   Supersedes: #839
   
   Quote from @AdityaSripal
   Context for the other folks reviewing: This is a problem in general not just for CCV. But currently, in CCV we want to initiate a transfer channel and know what the channelID is.
   
   So if we want to do this as part of third-party module logic, it's currently impossible with the codebase. Since, if you try to use channelKeeper directly you will need portCapability; and a third party module will not have transfer's portCapability.
   
   So we have to use the MsgServer, but the response doesn't include the channelID which we need since then we want to send transfer packets over the established channel.
   
   So this is going to be an issue for any third-party module that wants to initialize a channel of a different IBC application and then use that channel to send packets over
   
   ---
   
   Before we can merge this PR, please make sure that all the following items have been
   checked off. If any of the checklist items are not applicable, please leave them but
   write a little note why.
   
   - [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
   - [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
   - [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
   - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
   - [x] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
   - [x] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
   - [x] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
   - [x] Re-reviewed `Files changed` in the Github PR explorer
   - [ ] Review `Codecov Report` in the comment section below once CI passes
   
   (cherry picked from commit 7b7eb9f)

   

   rigelrozanski authored and mergify-bot committed Feb 7, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 0d2b924
   • Browse repository at this point

   Copy the full SHA

   0d2b924 View commit details

   Browse the repository at this point in the history