Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: cli command addition to v2 patch release line #827

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

colin-axner
Copy link
Contributor

Description

Reverts #679

This pr introduces new functions to the go API, this is traditionally not a patch release change. If a user upgraded to the patch release, used the new functions and then attempted to downgrade, their code would break which breaks the assumptions of a patch release.

This change should be included in a new minor version release.

I used the git revert command and fixed the CHANGELOG conflict

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@colin-axner colin-axner changed the title revert: cli command addition revert: cli command addition to v2 patch release line Feb 2, 2022
@colin-axner colin-axner merged commit 12b96bc into release/v2.0.x Feb 3, 2022
@colin-axner colin-axner deleted the colin/fix-release-v2-branch branch February 3, 2022 11:04
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants