Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add type constructors/validation for genesis types. #7554

Open
wants to merge 1 commit into
base: feat/ibc-eureka
Choose a base branch
from
Open

feat: add type constructors/validation for genesis types. #7554

wants to merge 1 commit into from

Conversation

DimitrisJim
Copy link
Contributor

Description

pending: tests

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DimitrisJim DimitrisJim force-pushed the jim/add-genesis-types-for-v2 branch 4 times, most recently from 034095d to 685bd70 Compare November 12, 2024 16:11
DimitrisJim
DimitrisJim commented Nov 12, 2024
View reviewed changes
modules/core/04-channel/v2/types/genesis.go
Receipts: receipts,
Commitments: commitments,
SendSequences: sendSeqs,
NextChannelSequence: nextChannelSequence,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will basically be duplicated for v1/v2. Need it here too tho in case some chain only uses eureka channels.

@DimitrisJim DimitrisJim marked this pull request as ready for review November 12, 2024 16:14
@DimitrisJim DimitrisJim mentioned this pull request Nov 13, 2024
Merged
10 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@chatton chatton Awaiting requested review from chatton chatton is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DimitrisJim