feat: create channel before invoking provide counterparty. #7420
+109
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
force-pushed
the
jim/test-runs-create-channel
branch
from
b871186
to
5663c83
Compare
DimitrisJim
commented
Oct 8, 2024
| @@ -8,4 +8,9 @@ const ( | |||
| // the counterparty key is imported from types instead of host because | |||
| // the counterparty key is not a part of the ics-24 host specification | |||
| CounterpartyKey = "counterparty" | |||
|
|
|||
| // CreatorKey is the key used to store the client creator in the client store | |||
There was a problem hiding this comment.
moved from 02-client
| @@ -66,3 +66,26 @@ func (k *Keeper) GetCounterparty(ctx context.Context, clientID string) (types.Co | |||
| k.cdc.MustUnmarshal(bz, &counterparty) | |||
| return counterparty, true | |||
| } | |||
|
|
|||
| // GetCreator returns the creator of the client. | |||
| func (k *Keeper) GetCreator(ctx context.Context, clientID string) (string, bool) { | |||
| k.ClientKeeper.SetCreator(ctx, clientID, msg.Signer) | ||
|
|
||
| return &clienttypes.MsgCreateClientResponse{}, nil | ||
| return &clienttypes.MsgCreateClientResponse{ClientId: clientID}, nil |
There was a problem hiding this comment.
don't know why this was never returned? can cherry pick to main too
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan,
chatton,
crodriguezvega,
gjermundgaraba and
bznein
as code owners
DimitrisJim
force-pushed
the
jim/test-runs-create-channel
branch
from
5663c83
to
8269633
Compare
10 tasks
AdityaSripal
approved these changes
Oct 9, 2024
| @@ -187,7 +188,7 @@ func (suite *KeeperTestSuite) TestRecvPacket() { | |||
| { | |||
| "failure: counterparty client identifier different than source channel", | |||
There was a problem hiding this comment.
test name is still using client identifier
There was a problem hiding this comment.
ugh yea, I've noticed this in other places too. Need to do a comb-through the diff and see where this has been missed.
|
gonna be doing a comb through for sticky 'client' references in a follow up. Going to make that clientID return change to main. |
4 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.