Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add OnTimeoutPacket to IBCModule V2 interface #7418

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

bznein
Copy link
Contributor

@bznein bznein commented Oct 8, 2024

Description

closes: #7411


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
62.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@bznein bznein merged commit 115749f into feat/ibc-eureka Oct 8, 2024
63 of 65 checks passed
@bznein bznein deleted the bznein/7411/OnTimeoutPacketIBCModuleV2 branch October 8, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants