Wire up simapp to use mock v2 modules #7401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal,
damiannolan,
crodriguezvega,
DimitrisJim,
gjermundgaraba and
bznein
as code owners
chatton
commented
Oct 7, 2024
testing/mock/v2/ibc_module.go
Outdated
Comment on lines
28
to
32
| func NewIBCModule() IBCModule { | ||
| return IBCModule{ | ||
| IBCApp: &IBCApp{}, | ||
| } | ||
| } |
There was a problem hiding this comment.
modified signature here to not include the IBCApp as an argument, think it's cleaner this way and don't think it would ever be required to pass a custom IBCApp at module creation time.
chatton
commented
Oct 7, 2024
| "github.com/cosmos/ibc-go/v9/modules/core/exported" | ||
| ) | ||
|
|
||
| // Keeper defines the IBC connection keeper | ||
| type Keeper struct { | ||
| Router *types.Router | ||
| Router *types.Router | ||
| RouterV2 *api.Router |
There was a problem hiding this comment.
not sure where this should actually go, we can figure this out later unless someone has a strong opinion about putting it somewhere now!
|
bznein
approved these changes
Oct 8, 2024
damiannolan
approved these changes
Oct 8, 2024
chatton
deleted the
cian/issue#7374-wire-up-simapp-to-use-mock-v2-modules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review after #7398
This PR wires up 2 mock applications in the simapp.
closes: #7374
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.