Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(callbacks/simapp): removed 'NewClientProposalHandler' #4656

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Sep 13, 2023

Description

NewClientProposalHandler was removed as part of #4620

closes: #XXXX

Commit Message / Changelog Entry

fix(callbacks/simapp): removed 'NewClientProposalHandler'

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srdtrk!

@srdtrk srdtrk merged commit b16a32c into main Sep 13, 2023
60 checks passed
@srdtrk srdtrk deleted the serdar/fix-callbacks-deps branch September 13, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callbacks middleware Issues for callbacks middleware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants