-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding docs for gov v1 migration #4628
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
cd37676
docs: adding docs for gov v1 migration
chatton f897bfc
Merge branch 'main' into cian/issue#4544-migration-docs-for-v8-govv1
chatton a8d1d71
chore: adding note about authority
chatton a0c8b8d
chore: run upgrade tests when upgrade_test.go changes
chatton 4cfca8b
Revert "chore: run upgrade tests when upgrade_test.go changes"
chatton 1f3de91
Merge branch 'main' into cian/issue#4544-migration-docs-for-v8-govv1
chatton 43d9ae6
formatting of code
crodriguezvega 3fde33e
chore: addressing PR feedback
chatton 89bdefb
Merge branch 'main' into cian/issue#4544-migration-docs-for-v8-govv1
chatton 1408613
Merge branch 'main' into cian/issue#4544-migration-docs-for-v8-govv1
chatton 62d9e58
Merge branch 'main' into cian/issue#4544-migration-docs-for-v8-govv1
chatton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -88,6 +88,39 @@ Each module has a corresponding `MsgUpdateParams` message with a `Params` which | |
|
||
Legacy params subspaces must still be initialised in app.go in order to successfully migrate from x/params to the new self-contained approach. See reference: https://github.com/cosmos/ibc-go/blob/main/testing/simapp/app.go#L1001-L1006 | ||
|
||
### Governance V1 migration | ||
|
||
Proposals have been migrated to [gov v1 messages](https://docs.cosmos.network/v0.50/modules/gov#messages) ref: [#4620](https://github.com/cosmos/ibc-go/pull/4620). The proposal `ClientUpdateProposal` has been removed and replaced with `MsgRecoverClient` and the proposal `UpgradeProposal` has been removed and replaced with `MsgIBCSoftwareUpgrade`. | ||
|
||
Ensure that the correct authority field is provided to the ibc keeper. | ||
|
||
Remove legacy proposal registration from app.go ref: [#4602](https://github.com/cosmos/ibc-go/pull/4602). | ||
|
||
Remove the 02-client proposal handler from the `govRouter`. | ||
|
||
```diff | ||
govRouter := govv1beta1.NewRouter() | ||
govRouter.AddRoute(govtypes.RouterKey, govv1beta1.ProposalHandler). | ||
AddRoute(paramproposal.RouterKey, params.NewParamChangeProposalHandler(app.ParamsKeeper)). | ||
- AddRoute(ibcclienttypes.RouterKey, ibcclient.NewClientProposalHandler(app.IBCKeeper.ClientKeeper)) | ||
``` | ||
|
||
Remove the UpgradeProposalHandler from the BasicModuleManager | ||
|
||
```diff | ||
app.BasicModuleManager = module.NewBasicManagerFromManager( | ||
app.ModuleManager, | ||
map[string]module.AppModuleBasic{ | ||
genutiltypes.ModuleName: genutil.NewAppModuleBasic(genutiltypes.DefaultMessageValidator), | ||
govtypes.ModuleName: gov.NewAppModuleBasic( | ||
[]govclient.ProposalHandler{ | ||
paramsclient.ProposalHandler, | ||
- ibcclientclient.UpgradeProposalHandler, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also the line with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe there was one handler that handled both cases |
||
}, | ||
), | ||
}) | ||
``` | ||
|
||
### Transfer migration | ||
|
||
An automatic migration handler (TODO: add link after https://github.com/cosmos/ibc-go/pull/3104 is merged) is configured in the transfer module to set the [denomination metadata](https://github.com/cosmos/cosmos-sdk/blob/95178ce036741ae6aa7af131fa9fccf3e13fff7a/proto/cosmos/bank/v1beta1/bank.proto#L96-L125) for the IBC denominations of all vouchers minted by the transfer module. | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we say something about making sure the correct authority is set in the ibc module keeper on app.go, and that it will default to gov if not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call