Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ica app version negotiation #410

Merged
merged 18 commits into from
Sep 20, 2021
Merged

feat: ica app version negotiation #410

merged 18 commits into from
Sep 20, 2021

Commits on Sep 15, 2021

  1. adding NegotiateAppVersion implementation and tests

    @damiannolan
    damiannolan committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    18990b4 View commit details
    Browse the repository at this point in the history

  2. updating GenerateAddress to return sdk.AccAddress, fixing tests

    @damiannolan
    damiannolan committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    49e2901 View commit details
    Browse the repository at this point in the history

  3. updating ica handshake flow to parse address from version string, fix… 

    …ing associated tests
    @damiannolan
    damiannolan committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    1f73b16 View commit details
    Browse the repository at this point in the history

  4. updating module_tests

    @damiannolan
    damiannolan committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    b967f08 View commit details
    Browse the repository at this point in the history

  5. derive ica addresses from module account addr

    @damiannolan
    damiannolan committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    52fe314 View commit details
    Browse the repository at this point in the history

  6. removing unused keys

    @damiannolan
    damiannolan committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    bd66f33 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. adding improved version validation, updating tests

    @damiannolan
    damiannolan committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    62e5c39 View commit details
    Browse the repository at this point in the history

  2. removing redundant local var - owner

    @damiannolan
    damiannolan committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    4ee74bf View commit details
    Browse the repository at this point in the history

  3. updating Delimiter godoc

    @damiannolan
    damiannolan committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    b2f3e3b View commit details
    Browse the repository at this point in the history

  4. updating validation logic

    @damiannolan
    damiannolan committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    c7d7804 View commit details
    Browse the repository at this point in the history

  5. adding test cases for ValidateVersion

    @damiannolan
    damiannolan committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    001313c View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. adding additional validation testcase, updating godocs

    @damiannolan
    damiannolan committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    d6725e1 View commit details
    Browse the repository at this point in the history

  2. updating Version -> VersionPrefix, error msgs, validation tests

    @damiannolan
    damiannolan committed Sep 17, 2021
    2 Configuration menu
    Copy the full SHA
    32240ff View commit details
    Browse the repository at this point in the history

  3. updating NewAppVersion func sig and usage

    @damiannolan
    damiannolan committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    e4af997 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. updating NewAppVersion args and returning more appropriate errors for… 

    … handshake
    @damiannolan
    damiannolan committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    18e9601 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'interchain-accounts' into damian/378-ica-set-addr-on-ctrl

    @damiannolan
    damiannolan authored Sep 20, 2021
    Configuration menu
    Copy the full SHA
    c691632 View commit details
    Browse the repository at this point in the history

  3. Update modules/apps/27-interchain-accounts/keeper/handshake.go 

    Co-authored-by: Sean King <[email protected]>
    @damiannolan @seantking
    damiannolan and seantking authored Sep 20, 2021
    Configuration menu
    Copy the full SHA
    3d5baab View commit details
    Browse the repository at this point in the history

  4. updating ValidateVersion godoc

    @damiannolan
    damiannolan committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    f400bdc View commit details
    Browse the repository at this point in the history