Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: silence deprecation warnings on golangci lint #3125

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Feb 8, 2023

Description

closes: #XXXX

Commit Message / Changelog Entry

NA
see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@damiannolan damiannolan changed the title attempting to silence deprecation warnings on golangci lint chore: silence deprecation warnings on golangci lint Feb 8, 2023
@damiannolan damiannolan marked this pull request as ready for review February 8, 2023 10:21
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I'm in favour of ignore the deprecated warnings for now.

@crodriguezvega crodriguezvega merged commit 5fc42fd into main Feb 8, 2023
@crodriguezvega crodriguezvega deleted the damian/silence-linter branch February 8, 2023 10:46
mergify bot pushed a commit that referenced this pull request Feb 8, 2023
stackman27 pushed a commit to stackman27/ibc-go that referenced this pull request Mar 13, 2023
@faddat faddat mentioned this pull request Jun 23, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants