Make isAllowedAddress private #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
commented
Jan 9, 2023
Comment on lines
+111
to
+119
| func isAllowedAddress(ctx sdk.Context, receiver string, allowedAddrs []string) bool { | ||
| for _, addr := range allowedAddrs { | ||
| ctx.GasMeter().ConsumeGas(gasCostPerIteration, "transfer authorization") | ||
| if addr == receiver { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } |
There was a problem hiding this comment.
I moved this to the bottom of the file as it was in between multiple public methods.
8 tasks
chatton
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
chatton
commented
Jan 9, 2023
| var ( | ||
| _ authz.Authorization = &TransferAuthorization{} | ||
| ) | ||
| var _ authz.Authorization = &TransferAuthorization{} |
There was a problem hiding this comment.
this is required to make formatting pass
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make isAllowedAddress private. This PR also fixes compilation issues in the unit tests.
part of: #2960
Commit Message / Changelog Entry
N/A
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.