Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip emission of unpopulated memo field in ics20 (backport #2651) #2654

Merged
merged 3 commits into from
Nov 3, 2022
Merged

fix: skip emission of unpopulated memo field in ics20 (backport #2651) #2654

merged 3 commits into from
Nov 3, 2022

Commits on Nov 2, 2022

  1. fix: skip emission of unpopulated memo field in ics20 (#2651) 

    ## Description

By setting `EmitDefaults` to false, we will not include an empty memo field in the marshaled json bytes

closes: #2645

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/10-structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes

(cherry picked from commit 393247b)
    @colin-axner @mergify
    colin-axner authored and mergify[bot] committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    9585b92 View commit details
    Browse the repository at this point in the history

  2. Update modules/apps/transfer/types/codec_test.go

    @damiannolan
    damiannolan authored Nov 2, 2022
    Configuration menu
    Copy the full SHA
    7ac8afb View commit details
    Browse the repository at this point in the history

  3. fix: merge conflict build

    @colin-axner
    colin-axner committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    37d8d45 View commit details
    Browse the repository at this point in the history