Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: renaming Result in IncentivizedAcknowledgement to AppAcknowledgement #1338

Merged
merged 4 commits into from
May 4, 2022

Conversation

seantking
Copy link
Contributor

Description

closes: #1326


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov-commenter
Copy link

Codecov Report

Merging #1338 (557e6d8) into main (bd08650) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1338   +/-   ##
=======================================
  Coverage   80.27%   80.27%           
=======================================
  Files         166      166           
  Lines       12023    12023           
=======================================
  Hits         9652     9652           
  Misses       1916     1916           
  Partials      455      455           
Impacted Files Coverage Δ
modules/apps/29-fee/types/ack.go 0.00% <0.00%> (ø)
modules/apps/29-fee/ibc_middleware.go 95.17% <100.00%> (ø)

proto/ibc/applications/fee/v1/ack.proto Outdated Show resolved Hide resolved
proto/ibc/applications/fee/v1/ack.proto Outdated Show resolved Hide resolved
@seantking seantking enabled auto-merge (squash) May 4, 2022 13:46
@seantking seantking merged commit 7bb609c into main May 4, 2022
@seantking seantking deleted the sean/issue#1326-rename-result branch May 4, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename result in IncentivizedAcknowledgement
4 participants