Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unspecified enum as zero value for InterchainAccountPacketData Type #484

Closed
3 tasks
damiannolan opened this issue Oct 12, 2021 · 0 comments
Closed
3 tasks

Unspecified enum as zero value for InterchainAccountPacketData Type #484

damiannolan opened this issue Oct 12, 2021 · 0 comments
Assignees
@damiannolan
Labels
27-interchain-accounts type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
Interchain Accounts

Comments

@damiannolan
Copy link
Member

Summary

The interchain accounts proto enum Type, used in InterchainAccountPacketData should contain an UNSPECIFIED/UNKNOWN enum as its zero value.
This can also be used for basic validation, ensuring an appropriate Type enum has been set.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added type: code hygiene Clean up code but without changing functionality or interfaces 27-interchain-accounts labels Oct 12, 2021
@damiannolan damiannolan added this to the Interchain Accounts milestone Oct 12, 2021
@damiannolan damiannolan mentioned this issue Oct 12, 2021
Merged
9 tasks
@damiannolan damiannolan self-assigned this Oct 13, 2021
@damiannolan damiannolan mentioned this issue Oct 13, 2021
Merged
9 tasks
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
@ethanfrey
Merge pull request cosmos#484 from CosmWasm/update-cosmos-sdk-0.42.4
f8fe581 
Bump cosmos sdk and tendermint versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
27-interchain-accounts type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Archived in project
Milestone
Interchain Accounts
Development

No branches or pull requests
1 participant
@damiannolan