Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return an error instead of a boolean in GetSelfConsensusState #42

Closed
cwgoes opened this issue Oct 30, 2020 · 0 comments · Fixed by #536
Closed

Return an error instead of a boolean in GetSelfConsensusState #42

cwgoes opened this issue Oct 30, 2020 · 0 comments · Fixed by #536
Labels
core good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
v3.0.0

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Oct 30, 2020

As title, since we're doing non-trivial input validation checks here.
@colin-axner colin-axner transferred this issue from cosmos/cosmos-sdk Mar 4, 2021
@colin-axner colin-axner added type: code hygiene Clean up code but without changing functionality or interfaces core good first issue Good for newcomers labels Apr 21, 2021
@technicallyty technicallyty mentioned this issue Nov 12, 2021
Merged
9 tasks
@crodriguezvega crodriguezvega added this to the v3.0.0 milestone Nov 17, 2021
@crodriguezvega crodriguezvega modified the milestones: v3.0.0, v3.0.0-rc0 Nov 29, 2021
faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
@jackzampolin
Merge PR #42: Add notes about setting up dev environment
8e79ed1
faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
@iammelea
Merge PR #42: melea ibc o0
94f4e37
faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
@jtieri @jackzampolin
Merge PR #42: Update README
7062ac8 
* Add Quickstart guide

* update existing documentation

* formatting fix

* correct numbering

* correct repo paths

* correct repo paths pt 2

* fix broken button

* change master to main

* add rpc-addr reminder in quickstart

* fix indentation

* consistent names

* build status

* fix build status

* fix build status pt2

* fix build status path

* small tweaks

* reorder steps

* bump relayer version number

* fix step numbering

* update

* fix wording

* remove step

* update readme to target v1.0.0 release

* Add more chains and small readme tweaks

Co-authored-by: Jack Zampolin <[email protected]>
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tzdybal
Block store (cosmos#42)
bc1ca00 
* Block store
* Status RPC call.
* In-memory block store (KISS) implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

refactor: GetSelfConsensusState return error instead of bool technicallyty/ibc-go
3 participants
@crodriguezvega @cwgoes @colin-axner