Skip to content

Commit

Permalink
nit(callbacks): removed unused testing func params (#4462)
Browse files Browse the repository at this point in the history
Co-authored-by: Carlos Rodriguez <[email protected]>
  • Loading branch information
srdtrk and crodriguezvega authored Aug 28, 2023
1 parent 01995a5 commit d5e55b7
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion modules/apps/callbacks/fee_transfer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ func (s *CallbacksTestSuite) TestIncentivizedTransferTimeoutCallbacks() {

s.ExecutePayPacketFeeMsg(fee)
preRelaySenderBalance := sdk.NewCoins(GetSimApp(s.chainA).BankKeeper.GetBalance(s.chainA.GetContext(), s.chainA.SenderAccount.GetAddress(), ibctesting.TestCoin.Denom))
s.ExecuteTransferTimeout(tc.transferMemo, 1)
s.ExecuteTransferTimeout(tc.transferMemo)

// after incentivizing the packets
s.AssertHasExecutedExpectedCallbackWithFee(tc.expCallback, tc.expSuccess, true, preRelaySenderBalance, fee)
Expand Down
8 changes: 4 additions & 4 deletions modules/apps/callbacks/ica_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func (s *CallbacksTestSuite) TestICACallbacks() {
s.Run(tc.name, func() {
icaAddr := s.SetupICATest()

s.ExecuteICATx(icaAddr, tc.icaMemo, 1)
s.ExecuteICATx(icaAddr, tc.icaMemo)
s.AssertHasExecutedExpectedCallback(tc.expCallback, tc.expSuccess)
})
}
Expand Down Expand Up @@ -131,14 +131,14 @@ func (s *CallbacksTestSuite) TestICATimeoutCallbacks() {
s.Run(tc.name, func() {
icaAddr := s.SetupICATest()

s.ExecuteICATimeout(icaAddr, tc.icaMemo, 1)
s.ExecuteICATimeout(icaAddr, tc.icaMemo)
s.AssertHasExecutedExpectedCallback(tc.expCallback, tc.expSuccess)
})
}
}

// ExecuteICATx executes a stakingtypes.MsgDelegate on chainB by sending a packet containing the msg to chainB
func (s *CallbacksTestSuite) ExecuteICATx(icaAddress, memo string, seq uint64) {
func (s *CallbacksTestSuite) ExecuteICATx(icaAddress, memo string) {
timeoutTimestamp := uint64(s.chainA.GetContext().BlockTime().Add(time.Minute).UnixNano())
icaOwner := s.chainA.SenderAccount.GetAddress().String()
connectionID := s.path.EndpointA.ConnectionID
Expand All @@ -159,7 +159,7 @@ func (s *CallbacksTestSuite) ExecuteICATx(icaAddress, memo string, seq uint64) {
}

// ExecuteICATx sends and times out an ICA tx
func (s *CallbacksTestSuite) ExecuteICATimeout(icaAddress, memo string, seq uint64) {
func (s *CallbacksTestSuite) ExecuteICATimeout(icaAddress, memo string) {
relativeTimeout := uint64(1)
icaOwner := s.chainA.SenderAccount.GetAddress().String()
connectionID := s.path.EndpointA.ConnectionID
Expand Down
4 changes: 2 additions & 2 deletions modules/apps/callbacks/transfer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func (s *CallbacksTestSuite) TestTransferTimeoutCallbacks() {
for _, tc := range testCases {
s.SetupTransferTest()

s.ExecuteTransferTimeout(tc.transferMemo, 1)
s.ExecuteTransferTimeout(tc.transferMemo)
s.AssertHasExecutedExpectedCallback(tc.expCallback, tc.expSuccess)
}
}
Expand Down Expand Up @@ -206,7 +206,7 @@ func (s *CallbacksTestSuite) ExecuteTransfer(memo string) {

// ExecuteTransferTimeout executes a transfer message on chainA for 100 denom.
// This message is not relayed to chainB, and it times out on chainA.
func (s *CallbacksTestSuite) ExecuteTransferTimeout(memo string, nextSeqRecv uint64) {
func (s *CallbacksTestSuite) ExecuteTransferTimeout(memo string) {
timeoutHeight := clienttypes.GetSelfHeight(s.chainB.GetContext())
timeoutTimestamp := uint64(s.chainB.GetContext().BlockTime().UnixNano())

Expand Down

0 comments on commit d5e55b7

Please sign in to comment.