fix: added check for empty path in 06-solomachine (#2741)

cosmos · Nov 18, 2022 · cb92f6f · cb92f6f
1 parent 1f140ea
commit cb92f6f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/modules/light-clients/06-solomachine/client_state.go b/modules/light-clients/06-solomachine/client_state.go
@@ -125,6 +125,10 @@ func (cs *ClientState) VerifyMembership(
 		return sdkerrors.Wrapf(sdkerrors.ErrInvalidType, "expected %T, got %T", commitmenttypes.MerklePath{}, path)
 	}
 
+	if merklePath.Empty() {
+		return sdkerrors.Wrap(commitmenttypes.ErrInvalidProof, "path is empty")
+	}
+
 	signBytes := &SignBytes{
 		Sequence:    sequence,
 		Timestamp:   timestamp,

diff --git a/modules/light-clients/06-solomachine/client_state_test.go b/modules/light-clients/06-solomachine/client_state_test.go
@@ -517,6 +517,13 @@ func (suite *SoloMachineTestSuite) TestVerifyMembership() {
 				},
 				false,
 			},
+			{
+				"empty path",
+				func() {
+					path = commitmenttypes.MerklePath{}
+				},
+				false,
+			},
 		}
 
 		for _, tc := range testCases {