Skip to content

Commit

Permalink
fix: updating port-id & fixing OnChanOpenInit bug (#321)
Browse files Browse the repository at this point in the history
* fix: updating port-id & fixing OnChanOpenInit bug

* Update modules/apps/27-interchain-accounts/keeper/handshake.go

Co-authored-by: colin axnér <[email protected]>
  • Loading branch information
seantking and colin-axner authored Aug 9, 2021
1 parent 38ebbff commit 881276f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions modules/apps/27-interchain-accounts/keeper/handshake.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,10 @@ func (k Keeper) OnChanOpenInit(
if version != types.Version {
return sdkerrors.Wrapf(channeltypes.ErrInvalidChannelVersion, "channel version must be '%s' (%s != %s)", types.Version, version, types.Version)
}
channelID, found := k.GetActiveChannel(ctx, portID)

existingChannelID, found := k.GetActiveChannel(ctx, portID)
if found {
return sdkerrors.Wrapf(porttypes.ErrInvalidPort, "existing active channel (%s) for portID (%s)", channelID, portID)
return sdkerrors.Wrapf(porttypes.ErrInvalidPort, "existing active channel (%s) for portID (%s)", existingChannelID, portID)
}

// Claim channel capability passed back by IBC module
Expand Down
2 changes: 1 addition & 1 deletion modules/apps/27-interchain-accounts/types/keys.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const (
// module supports
Version = "ics27-1"

PortID = "interchain-account"
PortID = "ibcaccount"

StoreKey = ModuleName
RouterKey = ModuleName
Expand Down

0 comments on commit 881276f

Please sign in to comment.