refactor: app version + add comment (#750)

cosmos · Jan 18, 2022 · 6504c39 · 6504c39
1 parent 7404d37
commit 6504c39
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/modules/apps/29-fee/ibc_module.go b/modules/apps/29-fee/ibc_module.go
@@ -56,6 +56,8 @@ func (im IBCModule) OnChanOpenInit(
 }
 
 // OnChanOpenTry implements the IBCModule interface
+// If the channel is not fee enabled the underlying application version will be returned
+// If the channel is fee enabled we merge the underlying application version with the ics29 version
 func (im IBCModule) OnChanOpenTry(
 	ctx sdk.Context,
 	order channeltypes.Order,
@@ -86,11 +88,11 @@ func (im IBCModule) OnChanOpenTry(
 		return "", err
 	}
 
-	if im.keeper.IsFeeEnabled(ctx, portID, channelID) {
-		return channeltypes.MergeChannelVersions(types.Version, appVersion), nil
+	if !im.keeper.IsFeeEnabled(ctx, portID, channelID) {
+		return appVersion, nil
 	}
 
-	return appVersion, nil
+	return channeltypes.MergeChannelVersions(types.Version, appVersion), nil
 }
 
 // OnChanOpenAck implements the IBCModule interface