update upgrade seq comparison in ChanUpgradeTimeout (#3905)

* update upgrade seq comparison * pr suggestions
cosmos · Jun 20, 2023 · 4f5f627 · 4f5f627
1 parent 6453bd4
commit 4f5f627
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/modules/core/04-channel/keeper/upgrade.go b/modules/core/04-channel/keeper/upgrade.go
@@ -448,8 +448,8 @@ func (k Keeper) ChanUpgradeTimeout(
 	// timeout for this sequence can only succeed if the error receipt written into the error path on the counterparty
 	// was for a previous sequence by the timeout deadline.
 	upgradeSequence := channel.UpgradeSequence
-	if upgradeSequence < prevErrorReceipt.Sequence {
-		return errorsmod.Wrapf(types.ErrInvalidUpgradeSequence, "previous counterparty error receipt sequence is greater than our current upgrade sequence: %d > %d", prevErrorReceipt.Sequence, upgradeSequence)
+	if upgradeSequence <= prevErrorReceipt.Sequence {
+		return errorsmod.Wrapf(types.ErrInvalidUpgradeSequence, "previous counterparty error receipt sequence is greater than or equal to our current upgrade sequence: %d > %d", prevErrorReceipt.Sequence, upgradeSequence)
 	}
 
 	if err := k.connectionKeeper.VerifyChannelUpgradeError(

diff --git a/modules/core/04-channel/keeper/upgrade_test.go b/modules/core/04-channel/keeper/upgrade_test.go
@@ -526,7 +526,7 @@ func (suite *KeeperTestSuite) TestChanUpgradeTimeout() {
 			"success: non-nil error receipt",
 			func() {
 				errReceipt = &types.ErrorReceipt{
-					Sequence: 1,
+					Sequence: 0,
 					Message:  types.ErrInvalidUpgrade.Error(),
 				}
 
@@ -628,6 +628,16 @@ func (suite *KeeperTestSuite) TestChanUpgradeTimeout() {
 			},
 			types.ErrInvalidUpgradeSequence,
 		},
+		{
+			"non-nil error receipt: error receipt seq equal to current upgrade seq",
+			func() {
+				errReceipt = &types.ErrorReceipt{
+					Sequence: 1,
+					Message:  types.ErrInvalidUpgrade.Error(),
+				}
+			},
+			types.ErrInvalidUpgradeSequence,
+		},
 	}
 
 	for _, tc := range testCases {