WIP generalized merkle proofs #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamsi
reviewed
Jul 25, 2018
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/tendermint/tendermint/crypto/merkle" |
There was a problem hiding this comment.
Do we really want tendermint as a dependency here? If so, wouldn't it make sense to do the merge (into tm) first? Or, do we want to move the interface ProofOperator to this repo instead? I like the latter as Tendermint will import iavl anyways.
| @@ -1,5 +1,30 @@ | |||
| # Changelog | |||
|
|
|||
| ## 0.10.0 (July 11, 2018) | |||
There was a problem hiding this comment.
The version here does not match the number in version.go.
| } | ||
| // XXX What is the encoding for keys? | ||
| // We should decode the key depending on whether it's a string or hex, | ||
| // maybe based on quotes and 0x prefix? |
There was a problem hiding this comment.
It is not clear if this is a todo that will be dealt later or if this should be clarified in this PR. @mossid?
|
This is superseded by #105 now. Can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on tendermint/tendermint#1912
Replaces #84