dep: Change the tendermint import #90
Comments
|
I think, I agree with @silasdavis here: We should duplicate the few methods we use from tendermint instead of updating the dependency. See also: #46 (comment) |
|
That sounds more optimal to me. However, I'm not sure what the ETA on that is. The fix I'm proposing is a very quick fix, which we can due in lieu of that change taking awhile. |
ValarDragon
added a commit
that referenced
this issue
Jul 25, 2018
This is done to remove the need for an override constraint for tendermint in the sdk. Closes #90
ValarDragon
added a commit
that referenced
this issue
Jul 25, 2018
This is done to remove the need for an override constraint for tendermint in the sdk. Closes #90
liamsi
pushed a commit
that referenced
this issue
Jul 26, 2018
This is done to remove the need for an override constraint for tendermint in the sdk. Closes #90
|
resolved by #91 |
ridenaio
pushed a commit
to idena-network/iavl
that referenced
this issue
Jul 1, 2019
This is done to remove the need for an override constraint for tendermint in the sdk. Closes cosmos#90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we're using an old tendermint version, and we use an equal sign. Because of this, we have to use an override for tendermint in the sdk's gopkg.toml. This makes it hard to import the sdk, and use any type from tendermint. This is because overrides do not apply transitively with dep. Only overrides in the top directory you're calling
dep ensurefrom get applied. Therefore in your downstream application you have to add an override import yourself, which is confusing,We should change the tendermint import to be
^v0.22.0, or^v0.22.4. (In the SDK its just getting replaced withv0.22.4anyway) This would alleviate issues in the future as well.The text was updated successfully, but these errors were encountered: