chore: Remove MergedRegistry warning (#45)

cosmos · Feb 21, 2023 · 8da0aa0 · 8da0aa0
1 parent d830bdb
commit 8da0aa0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## [v1.4.6](https://github.com/cosmos/gogoproto/releases/tag/v1.4.6) - 2023-02-21
+
+### Improvements
+
+- [#45](https://github.com/cosmos/gogoproto/pull/45) Remove the StdErr warning about file descriptor mismatches, which was deemed unclear and too invasive.
+
 ## [v1.4.5](https://github.com/cosmos/gogoproto/releases/tag/v1.4.5) - 2023-02-20
 
 ### Improvements

diff --git a/proto/merge.go b/proto/merge.go
@@ -6,7 +6,6 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"os"
 	"strings"
 
 	"github.com/google/go-cmp/cmp"
@@ -119,12 +118,6 @@ func mergedFileDescriptors(debug bool) (*descriptorpb.FileDescriptorSet, error)
 		if errStr.Len() > 0 {
 			return nil, fmt.Errorf(errStr.String())
 		}
-	} else {
-		// In production, we just log a warning to StdErr with the number of
-		// linter errors.
-		if len(checkImportErr) > 0 || len(diffErr) > 0 {
-			fmt.Fprintf(os.Stderr, "Got %d file descriptor import path errors and %d file descriptor mismatches. Run `proto.DebugFileDescriptorsMismatch` to debug them.\n", len(checkImportErr), len(diffErr))
-		}
 	}
 
 	slices.SortFunc(fds.File, func(x, y *descriptorpb.FileDescriptorProto) bool {