Skip to content

Conversation

@cloudgray
Copy link
Contributor

@cloudgray cloudgray commented Nov 17, 2025

Description

Closes: #839

  • In the precisebank test, the initial balance of the precisebank module is not initialized as intended, and balances minted in other tests are being aggregated together.

  • The root cause has not been clearly identified, and a temporary workaround is in place to prevent test failures.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@cloudgray cloudgray marked this pull request as ready for review November 17, 2025 07:42
@cloudgray cloudgray requested a review from vladjdk November 17, 2025 07:43
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.19%. Comparing base (7a38370) to head (d33cbaf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
+ Coverage   65.03%   65.19%   +0.16%     
==========================================
  Files         317      317              
  Lines       21615    21608       -7     
==========================================
+ Hits        14057    14088      +31     
+ Misses       6365     6356       -9     
+ Partials     1193     1164      -29     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mmsqe
Copy link
Contributor

mmsqe commented Nov 19, 2025

might related to common.U2560.Add(balance, balance), you can try revert the adjust and

cd evmd; go test -v -tags=test ./tests/integration -run "TestERC20KeeperTestSuite/TestRegisterERC20CodeHash|TestPreciseBankGenesis/TestExportGenesis/balances,_no_remainder"; cd ..

@cloudgray
Copy link
Contributor Author

cloudgray commented Nov 20, 2025

might related to common.U2560.Add(balance, balance), you can try revert the adjust and

cd evmd; go test -v -tags=test ./tests/integration -run "TestERC20KeeperTestSuite/TestRegisterERC20CodeHash|TestPreciseBankGenesis/TestExportGenesis/balances,_no_remainder"; cd ..

@mmsqe
It looks like you correctly identified the root cause.
After replacing all uses of common.U2560 with uint256.NewInt(0) and rerunning the entire integration test suite, I was able to reproduce the same error when running only TestPreciseBankKeeper!

In PR #842, once all common.U2560 usages are replaced with uint256.NewInt(0),

I think I can revert the helper that adjusts the module account balances in this PR and update the test code to verify the balances accordingly.

Or, will you fix test code in PR #842 ?

@cloudgray
Copy link
Contributor Author

PR #842 removed root cause of Issue #830 and Issue #839.
So we don't need this pr anymore.

@cloudgray cloudgray closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

independent execution failure of precisebank test

3 participants