-
Notifications
You must be signed in to change notification settings - Fork 120
test: fix precisebank keeper test #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
==========================================
+ Coverage 65.03% 65.19% +0.16%
==========================================
Files 317 317
Lines 21615 21608 -7
==========================================
+ Hits 14057 14088 +31
+ Misses 6365 6356 -9
+ Partials 1193 1164 -29 🚀 New features to boost your workflow:
|
|
might related to common.U2560.Add(balance, balance), you can try revert the adjust and |
@mmsqe In PR #842, once all common.U2560 usages are replaced with uint256.NewInt(0), I think I can revert the helper that adjusts the module account balances in this PR and update the test code to verify the balances accordingly. Or, will you fix test code in PR #842 ? |
Description
Closes: #839
In the precisebank test, the initial balance of the precisebank module is not initialized as intended, and balances minted in other tests are being aggregated together.
The root cause has not been clearly identified, and a temporary workaround is in place to prevent test failures.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch