Skip to content

fix: don't panic if evm mempool not used #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2025
Merged

fix: don't panic if evm mempool not used #730

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91b7080
fix: don't panic if evm mempool not used
yihuang Oct 16, 2025
b022117
Update CHANGELOG.md
yihuang Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
- [\#687](https://github.com/cosmos/evm/pull/687) Avoid blocking node shutdown when evm indexer is enabled, log startup failures instead of using errgroup.
- [\#689](https://github.com/cosmos/evm/pull/689) Align debug addr for hex address.
- [\#668](https://github.com/cosmos/evm/pull/668) Fix panic in legacy mempool when Reset() was called with a skipped header between old and new block.
- [\#]() Fix panic if evm mempool not used.

Check failure on line 25 in CHANGELOG.md

View workflow job for this annotation

GitHub Actions / markdownlint (cli2, minimal)

No empty links 

CHANGELOG.md:25 MD042/no-empty-links No empty links [Context: "[#]"] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md042.md

### IMPROVEMENTS

Expand Down
2 changes: 1 addition & 1 deletion server/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ func startInProcess(svrCtx *server.Context, clientCtx client.Context, opts Start
return err
}

if m, ok := evmApp.GetMempool().(*evmmempool.ExperimentalEVMMempool); ok {
if m, ok := evmApp.GetMempool().(*evmmempool.ExperimentalEVMMempool); ok && m != nil {
m.SetEventBus(bftNode.EventBus())
}
defer func() {
Expand Down
Loading