Skip to content

Conversation

@cloudgray
Copy link
Contributor

@cloudgray cloudgray commented Oct 14, 2025

Description

Closes: #741

Changes

  • decrease configured blocktime for test execution (9.5 -> 3s)
  • make almost all test cases be executed on single chain
  • fix test result validation logic
  • disable one non-deterministic test case
  • trivial refactoring

Consequence

  • decreased test execution time (35m -> 17m)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@cloudgray cloudgray marked this pull request as ready for review October 20, 2025 05:51
@cloudgray cloudgray requested a review from vladjdk October 20, 2025 11:01
@vladjdk vladjdk self-assigned this Oct 20, 2025
@vladjdk
Copy link
Member

vladjdk commented Oct 22, 2025

Approved with a few nits

@aljo242 aljo242 enabled auto-merge October 28, 2025 15:57
@aljo242 aljo242 disabled auto-merge October 28, 2025 15:58
@aljo242 aljo242 merged commit a0a98b9 into main Oct 28, 2025
17 of 19 checks passed
@aljo242 aljo242 deleted the refactor/systemtests branch October 28, 2025 15:58
zsystm pushed a commit to zsystm/evm that referenced this pull request Nov 2, 2025
* refactor(systemtests): change CheckTxsQueuedSync to CheckTxsQueuedAsync

* refactor(systemtests): remove calling AfterEachAction from TestTxsOrdering

* refactor(systemtests): refactor account type

* refactor(systemtests): apply mutex for accounts

* refactor(systemtests): apply account pool to test cases

* refactor(systemtests): apply account pool to eip7702 test

* refactor(systemtests): fix CheckTxsQueuedAsync

* refactor(systemtests): apply global chain

* refactor(systemtests): fix eip7702 test

* refactor(systemtests): fix test suite

* chore(systemtests): refactor test suite

* refactor(systemtests): fix eip712 test

* refactor(systemtests): fix validation method

* refactor(systemtests): refactor suite

* WIP: refactor test suite

* chore: modify makefile

* refactor: change upgrade test file name and apply --mempool.max-txs=0 flag

* refactor test suite

* refactor(systemtest): add test cases

* refactor(systemtest): enable chainupgrade test

* refactor(systemtest): refactor suite

* fix system tests

* fix system tests

* fix system tests

* refactor test cases

* chore: change test name

* fix upgrade test

* fix upgrade test

* resolve merge conflic

* test(systemtests): remove additional test accounts setting

* test(systemtests): fix helper function for pending txs

* test(systemtests): fix test case

* tet(systemtests): refactor test execution

* test(systemtests): remove account pool

* test(systemtests): fix pending cosmos tx verification

* chore: update CHANGELOG.md

* chore: update comments

* test(systemtests): increase block time of replacement test cases

* fix: rollback block time increase for test

* test(systemtests): apply 6s blocktime only for specific test case

* test(systemtests): apply 9s blocktime only for specific test case

* chore: modify Makefile

* test(systemtest): disable non-deterministic test case

* resolve merge conflict

---------

Co-authored-by: Alex | Cosmos Labs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test: systemtests take too much time and result is non-deterministic

4 participants