feat: support override for both evm and cosmos states #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmsqe
force-pushed
the
cosmos_override
branch
from
e97594b to
d89babe
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+204
to
+210
| for _, encodedData := range rawOverrides { | ||
| if overrideAccount, ok := encodedData.(map[string]interface{}); ok { | ||
| if cosmosOverrides := extractFromOverrideAccount(overrideAccount); cosmosOverrides != nil { | ||
| return nil, cosmosOverrides, nil | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
mmsqe
force-pushed
the
cosmos_override
branch
from
fcd6d1f to
48644cc
Compare
Comment on lines
+226
to
+240
| for stateType, stateValue := range overrideAccount { | ||
| if stateValue != nil { | ||
| if stateType == "" { | ||
| return make([]evmtypes.StoreStateDiff, 0) | ||
| } | ||
|
|
||
| if stateType == "state" || stateType == "stateDiff" { | ||
| if encodedStr, ok := stateValue.(string); ok { | ||
| if cosmosOverrides := decodeCosmosOverrides(encodedStr); cosmosOverrides != nil { | ||
| return cosmosOverrides | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
for test info
Closes: #504 #705
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch