Skip to content

Conversation

@almk-dev
Copy link
Member

@almk-dev almk-dev commented Oct 10, 2025

Description

Adds configurable validator powers to the testnet commands. The default is equal distribution if omitted. If there are fewer configurations than validators, it will repeat the last provided value for the remaining validators.

Closes: #321


Author Checklist

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@almk-dev almk-dev changed the title add configurable validator power feat(testnet): add flag to configure validator power Oct 10, 2025
@almk-dev almk-dev changed the title feat(testnet): add flag to configure validator power feat(testnet): add configurable testnet validator power Oct 10, 2025
@almk-dev almk-dev changed the title feat(testnet): add configurable testnet validator power feat(testnet): add configurable testnet validator powers Oct 10, 2025
@almk-dev almk-dev marked this pull request as ready for review October 10, 2025 19:44
@cloudgray cloudgray closed this Oct 14, 2025
@cloudgray cloudgray deleted the abdul/testnet-validator-power-flag branch October 14, 2025 01:53
@almk-dev almk-dev restored the abdul/testnet-validator-power-flag branch October 14, 2025 13:18
@almk-dev almk-dev reopened this Oct 14, 2025
Copy link
Member

@vladjdk vladjdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, one question

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 optional minor improvement

@vladjdk vladjdk added this pull request to the merge queue Oct 14, 2025
Merged via the queue into main with commit d6d2957 Oct 14, 2025
20 checks passed
@vladjdk vladjdk deleted the abdul/testnet-validator-power-flag branch October 14, 2025 21:08
vladjdk added a commit that referenced this pull request Oct 21, 2025
* Clean up events on EVM reversion in try-catch

* Problem: global mutable state in balance handler

* currently the balance handler in static precompile is a global mutable

* feat(testnet): add configurable testnet validator powers (#708)

* add configurable validator power

* add changelog

* update flag string

* update comments

* remove string parsing from validation function and update tests

---------

Co-authored-by: Vlad J <[email protected]>
Co-authored-by: Alex | Cosmos Labs <[email protected]>

* fix: don't panic if evm mempool not used (#730)

* fix: don't panic if evm mempool not used

* Update CHANGELOG.md

* fix: avoid tx with unsupported extension option for ExtensionOptionDynamicFeeTx (#733)

* fix: avoid nil pointer for tx evm raw cmd (#727)

* fix: avoid nil pointer for tx evm raw cmd

* cleanup

* cleanup

* fix: inconsistent block hash in json-rpc responses (#725)

* fix: inconsistent block hash in json-rpc responses

Update CHANGELOG.md

unify

unify

* fix test

---------

Co-authored-by: Vlad J <[email protected]>

* fix: non-deterministic evm pre-blocker (#729)

* fix: non-deterministic evm pre-blocker

Closes: #728

Solution:
- remove the state mutation out from the pre-blocker.
- production chains should put the state mutation part in their upgrade handler.

* Update CHANGELOG.md

---------

Co-authored-by: Vlad J <[email protected]>

* fix: wrong TransactionIndex in receipt (#723)

* fix: avoid 0 TransactionIndex in receipt

* add test

---------

Co-authored-by: Alex | Cosmos Labs <[email protected]>
Co-authored-by: Vlad J <[email protected]>

* add test for balance handler overwrite

* Fix unit test

* chore: align go-ethereum fork as main (#737)

* undo race removal

* Add precompile caller json to main files

* add debug comments

* fix imports

* test: example of configuring config.toml values in systest (#667)

* allow testnet config to be configured via flags

* configured

* use tag

* updates

* remove comment

* readme stuff

* maybe update sdk and comet versions

* replace the store

* fix

* just change ordering i guess

* deleting test case

* just skip it

* Update tests/systemtests/go.mod

Co-authored-by: Alex | Cosmos Labs <[email protected]>

* tidy

* add systemtest for cosmos tx compat

---------

Co-authored-by: Alex | Cosmos Labs <[email protected]>

* fix: evm mempool should be disabled if max-txs < 0 (#734)

* fix: evm mempool should be disabled if max-txs < 0

* Update CHANGELOG.md

* fix: add InitEvmCoinInfo upgrade to avoid panic when denom is not registered (#736)

---------

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Abdul Malek <[email protected]>
Co-authored-by: Alex | Cosmos Labs <[email protected]>
Co-authored-by: yihuang <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Tyler <[email protected]>
zsystm pushed a commit to zsystm/evm that referenced this pull request Nov 2, 2025
* add configurable validator power

* add changelog

* update flag string

* update comments

* remove string parsing from validation function and update tests

---------

Co-authored-by: Vlad J <[email protected]>
Co-authored-by: Alex | Cosmos Labs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update testnet command to make val power configurable

6 participants