-
Notifications
You must be signed in to change notification settings - Fork 113
fix!: Fix race condition in mempool blockchain impl #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+453
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
reviewed
Sep 24, 2025
aljo242
reviewed
Sep 24, 2025
mattac21
reviewed
Sep 24, 2025
mattac21
approved these changes
Sep 24, 2025
aljo242
approved these changes
Sep 24, 2025
zsystm
pushed a commit
to zsystm/evm
that referenced
this pull request
Nov 2, 2025
* Fix race condition in mempool blockchain impl * Add test for race condition * Update changelog * Fix lint * Update changelog entry * Update test * Add timeout to systemtests * Revert "Add timeout to systemtests" This reverts commit 8412abb. --------- Co-authored-by: Alex | Interchain Labs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Fixes the following race condition, which is verified when running the included test with the
-raceflag. As shown in the trace we need to make this thread safe because it can be called from goroutines within the txpool.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch