Skip to content

Conversation

@Pitasi
Copy link
Contributor

@Pitasi Pitasi commented Sep 23, 2025

Description

  • I enabled hardhat optimizations to reduce the code size (after my small change to IStaking, some tests contracts were exceeding the maximum allowed)
  • Changed StakingI.sol to return the already existing Description struct instead of a string
  • Recompiled all the contracts (here you'll see every single one is touched but my PR because of the optimizations)
  • Fix gas usage expectation in one integration test for erc20, the gas consumed is reduces, probably because of the enabled optimization

Closes #629.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@Pitasi Pitasi force-pushed the staking-return-full-description branch from 9420f0a to c535be9 Compare September 25, 2025 09:05
@vladjdk
Copy link
Member

vladjdk commented Oct 7, 2025

Approved - really dislike the fact that the .jsons are in the codebase and not in .gitignore despite the fact that I myself removed them. Will probably add them back. Overall, though, thanks!

@vladjdk vladjdk added this pull request to the merge queue Oct 7, 2025
Merged via the queue into cosmos:main with commit 80851f5 Oct 7, 2025
20 checks passed
mmsqe added a commit to MANTRA-Chain/mantrachain-e2e that referenced this pull request Oct 9, 2025
mmsqe added a commit to MANTRA-Chain/mantrachain-e2e that referenced this pull request Oct 17, 2025
* Problem: upstream evm is not integrated

* fix query validator

desc change in cosmos/evm#650

* skip

* cosmos_overrides for dynamic precompiles

* fix merge

* apply diff

* skip bugs

* gas cost changed slightly

* gas cost

* add more block hash assertion

* align extend

* ibc use address codec

* revert skip

Revert "ibc use address codec"

This reverts commit b5422f7.

* bump deps

* avoid app hash mismatch

* add solc to dev env

* native erc20 works now

* Update integration_tests/test_erc20.py

Signed-off-by: mmsqe <[email protected]>

* bump deps

* bump deps

* fix upgrade

* check extended_denom

* ibc address codec

* bump deps

* Revert "ibc address codec"

This reverts commit 346b425.

* bump deps

---------

Signed-off-by: yihuang <[email protected]>
Signed-off-by: mmsqe <[email protected]>
Co-authored-by: yihuang <[email protected]>
Co-authored-by: yihuang <[email protected]>
zsystm pushed a commit to zsystm/evm that referenced this pull request Nov 2, 2025
…eries (cosmos#650)

* enable hardhat solc optimizations

* precompile/staking: return full validator's description

* recompile all contracts

* fix erc20 test gas usage expectations

* fix solidity staking test

* fix solidity staking test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

staking: return full validators' description

2 participants