refactor!: clean up chain config

[almk-dev]

closes: #616, #371 and #522

The function assigns the result of evmtypes.GetEVMCoinExtendedDecimals() to the extendedDecimals variable and then immediately uses it as a field value in the struct evmtypes.EvmCoinInfo. Thereafter, the variable is never referenced, so its assignment is superfluous. The best fix is to eliminate the extendedDecimals variable completely, and directly use the function call as the value for the ExtendedDecimals field in evmtypes.EvmCoinInfo. Only the affected lines around the variable definition and struct literal need to be changed. No imports or other changes are required.

---

The best way to fix the problem is to remove the assignment to the local variable extendedDecimals, and instead use the function call to evmtypes.GetEVMCoinExtendedDecimals() directly in the assignment for the struct field ExtendedDecimals. Specifically, in the file tests/integration/x/vm/keeper_test_suite.go, in method SetupTest, remove line 108:

108: 	extendedDecimals := evmtypes.GetEVMCoinExtendedDecimals()

and, in the struct initialization, replace:

117: 			ExtendedDecimals: extendedDecimals,

with:

117: 			ExtendedDecimals: evmtypes.GetEVMCoinExtendedDecimals(),

No new methods, imports, or definitions are necessary.

---

To fix the unreachable statement, you need to examine the block directly before line 249 to identify what control flow blocks execution from reaching it. Most likely, a previous assertion or a method with FailNow or panic stops the test, making the subsequent statement unreachable. You should remove or reposition the unreachable statement (line 249) as appropriate, to ensure the code's logic and goals are maintained. If the statement is indeed not required, remove it. If it is necessary, restructure the test so that it becomes reachable (e.g., by ensuring no panic or failed assertion occurs before it).

For this snippet, edit only the lines you've been shown in file tests/integration/ante/test_evm_unit_04_validate.go. Remove line 249 if it is unnecessary, as further down, the necessary checks are performed, so it should be safe to remove.

---

The unreachable statement at line 503 should be examined and either relocated or removed. The recommended approach is:

• Inspect the lines immediately preceding 503 for an errant return, panic, or loop that never terminates.
• If the previous line contains an error or termination, ensure configurator.WithEVMCoinInfo(...) is located after all such statements so that it executes as intended.
• If the statement is genuinely unreachable and no longer needed, simply remove line 503.
• Only change the minimum necessary lines near line 503 within the FuzzBurnCoins function in file tests/integration/x/precisebank/test_burn_integration.go.

---

[almk-dev]

@Eric-Warehime @vladjdk please take a look for a first pass in terms of direction and generally use useful the new patterns are before I mark as r4r