feat: avoid unnecessary block notifications when the event bus is already set up #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change should have been included in cosmos@642c8e9
aljo242
reviewed
Aug 29, 2025
mmsqe
changed the title
aljo242
approved these changes
Sep 2, 2025
zsystm
pushed a commit
to zsystm/evm
that referenced
this pull request
Nov 2, 2025
…eady set up (cosmos#568) * chore: remove NotifyNewBlock in EndBlocker this change should have been included in cosmos@17522c5 * fix test * ensures block notify only triggered for legacy or non-event bus * fix reorg on restart cleanup --------- Co-authored-by: Alex | Interchain Labs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change should have been included in 642c8e9
Description
Closes: #563
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch